Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus render on AccentButton #60

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

oldium
Copy link
Contributor

@oldium oldium commented Oct 30, 2023

The AccentButton has no focus frame when navigated with Tab key, so fix this.

The AccentButton has no focus frame when navigated with Tab key, so fix
this.

Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
@rdbende
Copy link
Owner

rdbende commented Oct 30, 2023

Unfortunately neither of the other widgets has focus indicator, but thanks for adding it to the button anyway!

@oehhar
Copy link

oehhar commented Oct 30, 2023

Maybe off-topic. The Tk project has recently worked on the focus ring code: Tk commit 2b72403febce58be.

Great work, rdbene,
Harald

@rdbende
Copy link
Owner

rdbende commented Oct 30, 2023

Ahh, nice. Thank you Harald for letting me know!

@oehhar
Copy link

oehhar commented Oct 30, 2023

Have you seen the scaling presentation by Csaba at the Vienna OpenACS/TCL/Tk conference ?
Presentation
Video

It will be again in early summer in Vienna in 2024 ;-).

Thank you,
Harald

@rdbende
Copy link
Owner

rdbende commented Oct 30, 2023

Thanks for the links!
I haven't seen it yet, but I was aware of it for quite a while. It might come useful, as currently I'm in the process of porting the Sun Valley theme to use SVG image.

@oehhar
Copy link

oehhar commented Oct 30, 2023

Yes, great !
You might be interested in Csabas work on scaling on tablelist/scrollutil on nemeti.de.
And my favorite are the AWThemes, which are fully scalable, but unfortunately unmaintained.
The author has worked a lot on performance.

There is a nasty bug in Tk about image performance in the moment there is transparency involved, and since years no person fixing it...

@rdbende rdbende merged commit 997dbbe into rdbende:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants