Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of deprecated ftime() #251

Closed
donpellegrino opened this issue Mar 13, 2022 · 2 comments · Fixed by #253
Closed

Replace use of deprecated ftime() #251

donpellegrino opened this issue Mar 13, 2022 · 2 comments · Fixed by #253

Comments

@donpellegrino
Copy link
Contributor

donpellegrino commented Mar 13, 2022

The ftime() function is deprecated. Calls should be changed to use a different function:

src/static/textindex/suftest3.test.cpp:65:3: warning: 'ftime' is deprecated [-Wdeprecated-declarations]
                ftime(t);
                ^
/usr/include/x86_64-linux-gnu/sys/timeb.h:40:19: note: 'ftime' has been explicitly marked deprecated here
  __nonnull ((1)) __attribute_deprecated__;
                  ^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:251:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
                                                  ^

Note that this is a file in the hdt-cpp fork of the unmaintained libcds library. Issue #19 has identified libcds to be replaced with the sdsl-lite library. Putting the effort into replacing libcds will eliminate the class of problems of code maintenance on the old local copy of libcds.

@donpellegrino
Copy link
Contributor Author

Code without ftime() was already in there but had been conditioned out if a #if 1. Removing the weird constant conditional and fixing the syntax of mytimestruct's declaration fixes the problem.

donpellegrino pushed a commit to donpellegrino/hdt-cpp that referenced this issue Mar 13, 2022
@mielvds
Copy link
Member

mielvds commented Mar 14, 2022

So why was it commented out? There must have been a reason. AFAIK, this libcds branch has not been completed?

kamahen pushed a commit to JanWielemaker/hdt-cpp that referenced this issue Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants