Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jena to version 3.2.0 (#44) #45

Closed
wants to merge 4 commits into from
Closed

Conversation

osma
Copy link
Contributor

@osma osma commented Feb 13, 2017

This PR will upgrade the Jena dependency from 3.0.0/3.0.1 to the recently released 3.2.0, as proposed in issue #44.

I've split it into commits that upgrade one Jena version step at a time so if problems turn up later, it is easier to backtrack.

For the 3.0.1 to 3.1.0 upgrade there were some issues with the use of the class Tuple which was reworked (became an interface) in JENA-1107. But after analyzing the code I found out that the filter variable, which needed this class, was not actually used down the line. So I simply removed that dead code.

Also there was a check whether a DatasetGraph variable is of the type DatasetGraphMaker, which was removed in Jena 3.1.0. I figured that this check was probably not relevant (there is no casting after the check, just calling regular DatasetGraph methods) so I removed the test.

Finally in the upgrade to Jena 3.2.0 I replaced a call to DS.list() with new ArrayList(), which does the same, as the DS class was removed from Jena.

I've performed a very brief round of testing of all the command line utilities as well as starting a hdt-fuseki endpoint and issuing a SPARQL query. I couldn't find any issues. But it's always possible that there are some assumptions about Jena behavior built into hdt-java that have been adversely affected by the Jena upgrade.

@osma
Copy link
Contributor Author

osma commented Feb 16, 2017

I noticed by chance that @shawnsmith has also done an upgrade to Jena 3.1.0, a bit differently than I did (did not remove code but instead adapted to the changes in Jena classes). See shawnsmith@2de866d

@MarioAriasGa
Copy link
Member

Hi osma, thanks for your contribution, I pulled the changes from @shawnsmith branch and then applied your's on top so this merge is no longer needed.

@osma osma mentioned this pull request Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants