Upgrade Jena to version 3.2.0 (#44) #45
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will upgrade the Jena dependency from 3.0.0/3.0.1 to the recently released 3.2.0, as proposed in issue #44.
I've split it into commits that upgrade one Jena version step at a time so if problems turn up later, it is easier to backtrack.
For the 3.0.1 to 3.1.0 upgrade there were some issues with the use of the class
Tuple
which was reworked (became an interface) in JENA-1107. But after analyzing the code I found out that thefilter
variable, which needed this class, was not actually used down the line. So I simply removed that dead code.Also there was a check whether a
DatasetGraph
variable is of the typeDatasetGraphMaker
, which was removed in Jena 3.1.0. I figured that this check was probably not relevant (there is no casting after the check, just calling regularDatasetGraph
methods) so I removed the test.Finally in the upgrade to Jena 3.2.0 I replaced a call to
DS.list()
withnew ArrayList()
, which does the same, as theDS
class was removed from Jena.I've performed a very brief round of testing of all the command line utilities as well as starting a hdt-fuseki endpoint and issuing a SPARQL query. I couldn't find any issues. But it's always possible that there are some assumptions about Jena behavior built into
hdt-java
that have been adversely affected by the Jena upgrade.