Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Configuring Plugins To Build #291

Merged
merged 2 commits into from
Apr 29, 2014
Merged

Conversation

ajshort
Copy link
Contributor

@ajshort ajshort commented Mar 6, 2014

This creates a new build option for each plugin, allowing it to be disabled.

@rdiankov
Copy link
Owner

rdiankov commented Mar 7, 2014

good idea! i have some suggestions:

  • use the upper case of the string
string(TOUPPER ${PLUGIN} PLUGIN_UPPER)
option(OPENRAVE_PLUGIN_${PLUGIN_UPPER} "Build the ${PLUGIN} plugin" ON)
  • as far as i understand break() will exit from the for loop, which is not desired behavior. instead, can you just do:
if(OPENRAVE_PLUGIN_${PLUGIN_UPPER})
  # do the plugin processing
endif()

thanks,

@rdiankov
Copy link
Owner

just pinging. were you able to make the corresponding changes?

@ajshort
Copy link
Contributor Author

ajshort commented Mar 29, 2014

Sorry, it slipped off my radar. I've made the requested changes.

rdiankov added a commit that referenced this pull request Apr 29, 2014
Allow Configuring Plugins To Build
@rdiankov rdiankov merged commit e8476c3 into rdiankov:master Apr 29, 2014
@rdiankov
Copy link
Owner

thanks! just pulled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants