Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localhostmasquerade to Thunder plugin #130

Closed

Conversation

TeknoVenus
Copy link
Contributor

Description

Add localhostMasquerade functionality to Thunder plugin.

When enabled, Thunder will be available at 127.0.0.1:9998 inside the container in addition to 100.64.11.1:9998. This is useful for applications that don't correctly respect the THUNDER_ACCESS env var.

Refactor some iptables rule generation code for re-use, as localhost masquerade feature is used across Network, AS and Thunder plugins.

Test Procedure

When the Thunder plugin is configured with localhostMasquerade set:

"rdkPlugins": {
        "thunder": {
            "required": true,
            "dependsOn": ["networking"],
            "data": {
                "bearerUrl": "http://localhost",
                "localhostMasquerade": true
            }
        }
    }

Thunder should be accessible over 127.0.0.1:9998 inside the container.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

Stephen Foulds added 2 commits August 19, 2021 14:17
Refactor some iptables code for re-use across plugins.
@rdkcmf-jenkins
Copy link

Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/Dobby/130/rdkcentral/Dobby

  • Commit: 0c05053

Report detail: gist

@rdkcmf-jenkins
Copy link

WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: Spurious

  • Commit: 0c05053

@TeknoVenus TeknoVenus added the enhancement New feature or request label Nov 5, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Stephen Foulds seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@scthunderbolt
Copy link

Closed due to inactivity, please restore if still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants