[WebKitBrowser] Updating IndexedDB to match version 2.42 of WPEWebKit #5328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with 2.42 WebKit API
…stent and volatile paths
modeveci
reviewed
May 24, 2024
modeveci
previously approved these changes
Jun 10, 2024
MFransen69
previously approved these changes
Jun 13, 2024
modeveci
previously approved these changes
Jun 19, 2024
emutavchi
requested changes
Jun 20, 2024
| @@ -2811,20 +2814,24 @@ static GSourceFuncs _handlerIntervention = | |||
| wpeDiskCachePath = g_build_filename(g_get_user_cache_dir(), "wpe", "disk-cache", nullptr); | |||
| } | |||
| g_mkdir_with_parents(wpeDiskCachePath, 0700); | |||
|
|
|||
| #if WEBKIT_CHECK_VERSION(2, 42, 0) | |||
There was a problem hiding this comment.
Can you enable this starting from 2.38, currently build is broken with:
WebKitImplementation.cpp:2883:44: error: 'indexedDBPath' was not declared in this scope
modeveci
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of that, base data and cache directories were added to WebsiteDataManager as persistent and volatile paths set through the Thunder configuration.