Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gst task unittests #169

Merged
merged 18 commits into from
Aug 11, 2023
Merged

Refactor gst task unittests #169

merged 18 commits into from
Aug 11, 2023

Conversation

skyfroxl
Copy link
Collaborator

Summary: Refactor all gst task unittests into one common base source.
Type: Feature
Test Plan: UTs
Jira: RIALTO-263

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/37148/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/74976/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/4592/ started

@github-actions
Copy link

tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:90:18: style: Local variable 'kItHappenedInThePast' shadows outer variable [shadowVariable]
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:63:18: note: Shadowed declaration
constexpr gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:90:18: note: Shadow variable
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:91:18: style: Local variable 'kItWillHappenInTheFuture' shadows outer variable [shadowVariable]
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:64:18: note: Shadowed declaration
constexpr gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:91:18: note: Shadow variable
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:92:19: style: Local variable 'kDuration' shadows outer variable [shadowVariable]
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:65:19: note: Shadowed declaration
constexpr int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:92:19: note: Shadow variable
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:107:18: style: Local variable 'kItHappenedInThePast' shadows outer variable [shadowVariable]
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:63:18: note: Shadowed declaration
constexpr gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:107:18: note: Shadow variable
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:108:18: style: Local variable 'kItWillHappenInTheFuture' shadows outer variable [shadowVariable]
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:64:18: note: Shadowed declaration
constexpr gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:108:18: note: Shadow variable
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:109:19: style: Local variable 'kDuration' shadows outer variable [shadowVariable]
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:65:19: note: Shadowed declaration
constexpr int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:109:19: note: Shadow variable
const int64_t kDuration{9000000000};
^

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/7588/ started.

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17754/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17755/

@github-actions
Copy link

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 79.5% to 79.2%
Functions coverage stays unchanged and is: 84.1%

@github-actions
Copy link

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 79.4% to 79.2%
Functions coverage stays unchanged and is: 84.1%

@github-actions
Copy link

tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:91:18: style: Local variable 'kItHappenedInThePast' shadows outer variable [shadowVariable]
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:64:18: note: Shadowed declaration
constexpr gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:91:18: note: Shadow variable
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:92:18: style: Local variable 'kItWillHappenInTheFuture' shadows outer variable [shadowVariable]
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:65:18: note: Shadowed declaration
constexpr gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:92:18: note: Shadow variable
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:93:19: style: Local variable 'kDuration' shadows outer variable [shadowVariable]
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:66:19: note: Shadowed declaration
constexpr int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:93:19: note: Shadow variable
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:108:18: style: Local variable 'kItHappenedInThePast' shadows outer variable [shadowVariable]
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:64:18: note: Shadowed declaration
constexpr gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:108:18: note: Shadow variable
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:109:18: style: Local variable 'kItWillHappenInTheFuture' shadows outer variable [shadowVariable]
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:65:18: note: Shadowed declaration
constexpr gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:109:18: note: Shadow variable
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:110:19: style: Local variable 'kDuration' shadows outer variable [shadowVariable]
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:66:19: note: Shadowed declaration
constexpr int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:110:19: note: Shadow variable
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:1691:0: style: The function 'triggerRemoveSourceVideo' is never used. [unusedFunction]

^

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/37152/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/74987/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/4595/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/7594/ started.

@github-actions
Copy link

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 79.4% to 79.2%
Functions coverage stays unchanged and is: 84.1%

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/37157/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/74989/ started.

@github-actions
Copy link

tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:91:18: style: Local variable 'kItHappenedInThePast' shadows outer variable [shadowVariable]
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:64:18: note: Shadowed declaration
constexpr gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:91:18: note: Shadow variable
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:92:18: style: Local variable 'kItWillHappenInTheFuture' shadows outer variable [shadowVariable]
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:65:18: note: Shadowed declaration
constexpr gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:92:18: note: Shadow variable
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:93:19: style: Local variable 'kDuration' shadows outer variable [shadowVariable]
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:66:19: note: Shadowed declaration
constexpr int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:93:19: note: Shadow variable
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:108:18: style: Local variable 'kItHappenedInThePast' shadows outer variable [shadowVariable]
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:64:18: note: Shadowed declaration
constexpr gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:108:18: note: Shadow variable
const gint64 kItHappenedInThePast = 1238450934;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:109:18: style: Local variable 'kItWillHappenInTheFuture' shadows outer variable [shadowVariable]
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:65:18: note: Shadowed declaration
constexpr gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:109:18: note: Shadow variable
const gint64 kItWillHappenInTheFuture = 3823530248;
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:110:19: style: Local variable 'kDuration' shadows outer variable [shadowVariable]
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:66:19: note: Shadowed declaration
constexpr int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:110:19: note: Shadow variable
const int64_t kDuration{9000000000};
^
tests/media/server/gstplayer/genericPlayer/common/TasksTestsBase.cpp:1691:0: style: The function 'triggerRemoveSourceVideo' is never used. [unusedFunction]

^

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/4599/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/7595/ started.

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17782/

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/37194/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/75013/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/4629/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/7624/ started.

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17847/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17848/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17849/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17850/

@github-actions
Copy link

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 79.4% to 79.5%
Functions coverage stays unchanged and is: 84.1%

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/github-triggered/37196/ started

@rdkcmf-jenkins
Copy link

https://jenkins.code.rdkcentral.com/job/build-component/75021/ started.

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/4631/ started

@rdkcmf-jenkins
Copy link

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/7631/ started.

@github-actions
Copy link

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 79.4% to 79.5%
Functions coverage stays unchanged and is: 84.1%

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17851/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17852/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17853/

@github-actions
Copy link

Coverage statistics of your commit:
Congratulations, your commit improved lines coverage from: 79.4% to 79.5%
Functions coverage stays unchanged and is: 84.1%

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17861/

@rdkcmf-jenkins
Copy link

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17862/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17866/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17867/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17868/

@rdkcmf-jenkins
Copy link

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/17893/

@skyfroxl skyfroxl requested a review from aczs August 11, 2023 10:39
@skyfroxl skyfroxl merged commit 76fa8be into master Aug 11, 2023
8 checks passed
@skyfroxl skyfroxl deleted the Refactor_gst_task_unittests branch August 11, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyshaha1 skyshaha1 skyshaha1 approved these changes

@skywojciechowskim skywojciechowskim skywojciechowskim approved these changes

@aczs aczs Awaiting requested review from aczs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skyfroxl @rdkcmf-jenkins @skywojciechowskim @skyshaha1