Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code pip installable #1

Closed
cthoyt opened this issue Oct 23, 2020 · 1 comment · Fixed by #2
Closed

Make code pip installable #1

cthoyt opened this issue Oct 23, 2020 · 1 comment · Fixed by #2

Comments

@cthoyt
Copy link
Contributor

cthoyt commented Oct 23, 2020

Hi, I think your notebook is really interesting! Would you be willing to accept a PR that makes the code in this repository pip installable so it's easier for others to reuse?

I've made PRs on lots of repositories with scientific code, and will do my best to explain what I did so you can learn something
@iwatobipen
Copy link
Collaborator

iwatobipen commented Oct 23, 2020 •
edited
Loading

Hi @cthoyt ,
That's wonderful!
If we can install it with pip and use more easily, it seems very useful.
PR is really appreciated.
Thanks.

@cthoyt cthoyt mentioned this issue Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@iwatobipen @cthoyt