Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the boost version to 1.62 #42

Open
greglandrum opened this issue Dec 21, 2016 · 15 comments
Open

Update the boost version to 1.62 #42

greglandrum opened this issue Dec 21, 2016 · 15 comments

Comments

@greglandrum
Copy link
Member

Are we constrained to stick with boost 1.56 or could we go ahead and update to the most recent version?

@rvianello
Copy link
Contributor

in general, I think we would mainly need to check if we are able to build rdkit with boost 1.62 on centos6

I am not aware about the specific constraints, but I think @bp-kelley tested several versions of boost recently and suggested using 1.58, so he might have some more concrete suggestions.

@greglandrum
Copy link
Member Author

I can do the centos6 test; I have a VM that I use for my conda testing.
I'll give that a try this evening.

@greglandrum
Copy link
Member Author

I wonder about VS2008? (Or maybe we should explore moving to something "a bit" more up-to-date for py27 on windows)

@greglandrum
Copy link
Member Author

greglandrum commented Dec 22, 2016

I updated the recipe for boost and the rdkit to use boost=1.62 and the rdkit release branch (just to ensure up-to-date production code for the testing phase) and it builds fine on centos6 with the default compilers.

I'll push a branch and give it a try on the mac and windows too.
And, of course, things don't "just work" on the Mac. I'll have to explore a bit more.

@greglandrum
Copy link
Member Author

the other thing that is worth considering, and that I'm trying now as well, would be to use the normal conda version of boost: 1.61. This would spare us from having to worry about it at all.

@rvianello
Copy link
Contributor

boost 1.61 I'm afraid would still cause problems on the recent linux distros, unless a fix for boost::multiprecision was backported into the anaconda package. I was testing a build using the packages from conda-forge (that provides boost 1.62, and a lot of other updates), but I'm still troubleshooting some small issues.

regarding py27 on windows, if we move away from vc2008, then I guess we can just use vc2015, I'm not sure using any intermediate release would be different in terms of portability, and I think most (if not all) of the earlier vc releases are no longer available for download.

@greglandrum
Copy link
Member Author

But 1.61 would just cause problems for people who want to build their own version of the RDKit using the conda recipes, right? That's not a huge concern to me.

@greglandrum
Copy link
Member Author

greglandrum commented Dec 22, 2016

v1.61 (the conda version) works fine on:

  • windows (using vc2015)
  • centos6
  • Mac

@rvianello
Copy link
Contributor

ah, yes, streamlining the overall process and reducing the number of custom packages would surely help (I initially misunderstood the intention could be related to the bug in boost < 1.62)

@greglandrum
Copy link
Member Author

Na, the intention is just to simplify. :-)

@greglandrum
Copy link
Member Author

v1.61 also seems to be somewhat problematic with gcc5.x (Ubuntu 16.04). The regex problem with the SLN library appears there

@greglandrum
Copy link
Member Author

but I didn't yet try the conda version. I assume that has the same problem

@bp-kelley
Copy link

bp-kelley commented Dec 22, 2016 via email

@bp-kelley
Copy link

bp-kelley commented Dec 23, 2016 via email

@bp-kelley
Copy link

bp-kelley commented Dec 23, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants