Improve python and numpy detection - fixes #12 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| python_prefix = %x(#{python_executable} -c 'import sysconfig;print(sysconfig.get_config_var("prefix"))').chomp | ||
| python_include = %x(#{python_executable} -c 'import sysconfig;print(sysconfig.get_path("include"))').chomp | ||
| python_version = "python" + %x(#{python_executable} -c 'import sys;print(sys.version[:3])').chomp | ||
| args << "-DPYTHON_EXECUTABLE='#{python_executable}'" |
There was a problem hiding this comment.
I think the main cause of issue #12 is that PYTHON_EXECUTABLE isn't set when using homebrew python, and this is used by FindNumPy.cmake to set PYTHON_NUMPY_INCLUDE_PATH.
However, PYTHON_NUMPY_INCLUDE_PATH is still somehow set correctly on my machine, but this clearly isn't the case for everyone.
greglandrum
added a commit
that referenced
this pull request
Jul 25, 2014
Improve python and numpy detection - fixes #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should more explicitly help cmake locate the proper python and numpy paths.
I think this should fix issue #12, although it is a bit hard to test because I can't replicate the issue.