Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev into master #198

Open
wants to merge 68 commits into
base: master
Choose a base branch
from
Open

Dev into master #198

wants to merge 68 commits into from

Commits on Dec 9, 2022

  1. Add notice pointing at new repos.

    @martin-hughes @Danack
    martin-hughes authored and Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d1bd25a View commit details
    Browse the repository at this point in the history

  2. Updated words to be accurate for Dec 2022.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    283779d View commit details
    Browse the repository at this point in the history

  3. Updated to modern version of PHPUnit and add phpunit switcher for CI.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    57a4275 View commit details
    Browse the repository at this point in the history

  4. Dynamic property creation is no longer a thing.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    93920b0 View commit details
    Browse the repository at this point in the history

  5. Change config to avoid warnings on coverage only tests.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    0460307 View commit details
    Browse the repository at this point in the history

  6. Relax access for properties so that they can be read by tests.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c254996 View commit details
    Browse the repository at this point in the history

  7. Ignore files that should never be added.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c911e18 View commit details
    Browse the repository at this point in the history

  8. Migrated PHPUnit config file to modern format.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    15d947b View commit details
    Browse the repository at this point in the history

  9. Fix majority of tests. Remaining ones are more difficult.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1e59a90 View commit details
    Browse the repository at this point in the history

  10. Fix two mocking errors.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    2ad6fc3 View commit details
    Browse the repository at this point in the history

  11. Skip tests that need proper investigation.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e57ba16 View commit details
    Browse the repository at this point in the history

  12. Fix test testDelegationDoesntMakeObject

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c6709a7 View commit details
    Browse the repository at this point in the history

  13. Continue running in CI on failures for now.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d01a31a View commit details
    Browse the repository at this point in the history

  14. Try removing actual phpunit to see if it makes tests run.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    23274ea View commit details
    Browse the repository at this point in the history

  15. Remove old annotations as they are giving deprecation warnings.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    f6d498e View commit details
    Browse the repository at this point in the history

  16. Double-check having phpunit breaks CI.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    321aae3 View commit details
    Browse the repository at this point in the history

  17. Update badge to my repo for now.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b2fbae6 View commit details
    Browse the repository at this point in the history

  18. Make name easier to understand.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    067bc79 View commit details
    Browse the repository at this point in the history

  19. Investigate when behaviour changed.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    0f3b07f View commit details
    Browse the repository at this point in the history

  20. Remove phpunit again, it is causing a problem as a direct dependency.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    aff99a5 View commit details
    Browse the repository at this point in the history

  21. Adjust tests expectation based on which version of PHP they are being… 

    … run on, as the PHP exception message changed.
    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    8b46ab0 View commit details
    Browse the repository at this point in the history

  22. Correct typos.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    ae2dee4 View commit details
    Browse the repository at this point in the history

  23. Fix spelling to work on PHP 7.x - might still be broken on 8+

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b7771b8 View commit details
    Browse the repository at this point in the history

  24. Hack fix for InjectorTest::testNonConcreteDependencyWithDefaultValueT… 

    …hroughAlias.
    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d037f7d View commit details
    Browse the repository at this point in the history

  25. Unskip other tests that are now working.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    7ecc162 View commit details
    Browse the repository at this point in the history

  26. Drop support for PHP < 7.3

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    874b26b View commit details
    Browse the repository at this point in the history

  27. fix #129

    @Danack
    koenhoeymans authored and Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    113f8c7 View commit details
    Browse the repository at this point in the history

  28. Add PHP 8.2 to testing.

    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1f8809a View commit details
    Browse the repository at this point in the history

  29. Change test rather than changing code...technically a BC break, but p… 

    …robably appropriate.
    @Danack
    Danack committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    76070d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Run CI against PHP 7.2

    @Danack
    Danack committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    95067d2 View commit details
    Browse the repository at this point in the history

  2. Remove leading slashes and question marks in one go.

    @Danack
    Danack committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    5ed3ece View commit details
    Browse the repository at this point in the history

  3. Remove duplicate line. That has been there for seven years.

    @Danack
    Danack committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    9f3bd4b View commit details
    Browse the repository at this point in the history

  4. Switch back to simple-phpunit as although PHPUnit 8.5.31 works on PHP… 

    … 8, it doesn't generate coverage reports.
    @Danack
    Danack committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    4707dad View commit details
    Browse the repository at this point in the history

  5. Fewer words = more better.

    @Danack
    Danack committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    fac542d View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Added link to lazy instantiation version of Auryn, and words on why i… 

    …t wasn't included.
    @Danack
    Danack committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    d730160 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Added words to explain why #35 was rejected.

    @Danack
    Danack committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    7d500bc View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2022

  1. Wrote some words on why variadics aren't supported.

    @Danack
    Danack committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    150f057 View commit details
    Browse the repository at this point in the history

  2. Correct badge URL.

    @Danack
    Danack committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    d52795d View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Changed 'typehint' to 'type'.

    @Danack
    Danack committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    0f44000 View commit details
    Browse the repository at this point in the history

  2. Added more words to document why features were excluded. 

    #145
#133
    @Danack
    Danack committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    6c06f16 View commit details
    Browse the repository at this point in the history

  3. Completed sentence in docs.

    @Danack
    Danack committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    6e92e26 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. Added words for static initialisation.

    @Danack
    Danack committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    f93349d View commit details
    Browse the repository at this point in the history

  2. More words.

    @Danack
    Danack committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    bcaa1d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Update php-cs-fixer and fix CS issues.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    af851c1 View commit details
    Browse the repository at this point in the history

  2. Remove 5.3 compatibility code.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d8bcb0a View commit details
    Browse the repository at this point in the history

  3. Throwable has been the base exception since PHP 7.0, so the second ca… 

    …tch would only have been of use on versions < 7.0
    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    de20dcf View commit details
    Browse the repository at this point in the history

  4. Upgrading github actions/checkout

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d5d05dd View commit details
    Browse the repository at this point in the history

  5. Use more appropriate exception for during config process.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    a9a6146 View commit details
    Browse the repository at this point in the history

  6. CS

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    dfde7c8 View commit details
    Browse the repository at this point in the history

  7. Switch to phpbench as Atheltic was abandoned.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f46c70c View commit details
    Browse the repository at this point in the history

  8. Add coverage tests for Executable.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e29bbec View commit details
    Browse the repository at this point in the history

  9. Added tests and improved error messages, and wrote documentation for … 

    …injector->make()/excute() args.
    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e00a69b View commit details
    Browse the repository at this point in the history

  10. Added note on static method of how it could be private.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    65a1517 View commit details
    Browse the repository at this point in the history

  11. Added phpbench config file.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    83592b6 View commit details
    Browse the repository at this point in the history

  12. Ignore lines for code coverage, so that testing can be at 100% locally.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    cef6506 View commit details
    Browse the repository at this point in the history

  13. Document behaviour of prepare replacement.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    829fd95 View commit details
    Browse the repository at this point in the history

  14. Move check for whether an object was created by a delegate method to … 

    …a better place.

Also avoids the need for an error suppression usage.
    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    12e8f2c View commit details
    Browse the repository at this point in the history

  15. Prevent double sharing of same type.

    @Danack
    Danack committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    2d03a9e View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Add test coverage for new in initializer.

    @Danack
    Danack committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f2f81c2 View commit details
    Browse the repository at this point in the history

  2. Added test coverage and note on why optional dependencies are not cre… 

    …ated.
    @Danack
    Danack committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f7cb772 View commit details
    Browse the repository at this point in the history

  3. Fix property name.

    @Danack
    Danack committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    46b7998 View commit details
    Browse the repository at this point in the history

  4. Fix trailing comma.

    @Danack
    Danack committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    322c91d View commit details
    Browse the repository at this point in the history

  5. Minimum version is PHP 7.2 which is > 5.6 so check is not needed.

    @Danack
    Danack committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ae0e21e View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Adding non-trivial benchmark.

    @Danack
    Danack committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e3e9d00 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. WIP words...

    @Danack
    Danack committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    64f32c4 View commit details
    Browse the repository at this point in the history

  2. Reasonable draft of words.

    @Danack
    Danack committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    5a3e751 View commit details
    Browse the repository at this point in the history

  3. Typos.

    @Danack
    Danack committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    4cd4b4e View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Move benchmarks to their own job, and only run on two versions of PHP.

    @Danack
    Danack committed May 23, 2023
    Configuration menu
    Copy the full SHA
    b739eb9 View commit details
    Browse the repository at this point in the history