Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change/split test settings setup #690

Closed
afuetterer opened this issue Sep 3, 2023 · 1 comment
Closed

Change/split test settings setup #690

afuetterer opened this issue Sep 3, 2023 · 1 comment

Comments

@afuetterer
Copy link
Member

Rationale / Begründung

Can the test settings testing/config/settings be set up differently? It is a little difficult to wrap your head around the settings setup.

Affected

Tests.

Minimal functionality

I propose the following setup:

  • base settings
  • dev settings for local development
  • testing settings for running the unit tests

Remove the mysql, postgres, sqlite modules and choose the database backend from an env variable.

What do you think?

References / Verweise

Similar to:

@jochenklar
Copy link
Member

Hey @afuetterer , I updated the settings to make them similar to the new rdmo-app (with an identical testing/config/settings/__init__.py) and put the database config in testing/config/settings/base.py based on a environment variable GITHUB_DB_BACKEND.

CalamityC pushed a commit to CalamityC/rdmo that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants