Fix edeploy plugin puts too much data in Ironic extra column #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edeploy plugin stores all of the facts it collects in the extra column of the Ironic db. When using real hardware, edeploy collects a large amount of facts and can lead to overflowing that column. This patch fixes this by storing the collected data in Swift instead. This makes it usable more generically as well. Anything stored on the 'data' key in the dictionary returned by the ramdisk is stored as a JSON encoded string in a Swift object. The object is named 'extra_hardware-<node uuid>' and is stored in the 'ironic-inspector' container. Change-Id: Ie9e017df735a95350991ce419fa3b64249819d70 Closes-Bug: 1461252 Conflicts: example.conf ironic_discoverd/plugins/edeploy.py ironic_discoverd/test/test_plugins_edeploy.py setup.py tox.ini
|
I tested this backport. We probably want to add the configuration options to instack-undercloud before merging this. |
|
We actually want to propose this to mgt-kilo. |
trown
pushed a commit
to rdo-management/instack-undercloud
that referenced
this pull request
Jun 15, 2015
We need to configure Swift credentials in order to use: rdo-management/ironic-discoverd#2 That backport will resolve the issue reported in bz#1227755 (discoverd edeploy plugin puts too much data in Ironic extra column). Change-Id: I53c7c50e9b02b3ebc62b1d85556d316dd0bc9442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edeploy plugin stores all of the facts it collects in the extra
column of the Ironic db. When using real hardware, edeploy collects a
large amount of facts and can lead to overflowing that column.
This patch fixes this by storing the collected data in Swift instead.
This makes it usable more generically as well. Anything stored on the
'data' key in the dictionary returned by the ramdisk is stored as a
JSON encoded string in a Swift object. The object is named
'extra_hardware-' and is stored in the 'ironic-inspector'
container.
Backport of: https://review.openstack.org/#/c/189427