Skip to content

Conversation

kou
Copy link
Member

@kou kou commented Jan 14, 2014

I find that auto "rake newb" feature by "rake" without any arguments when the following case:

  • racc gem isn't installed.
  • lib/rdoc/rd/block_parser.rb (racc output) exists but it is older than lib/rdoc/rd/block_parser.ry (racc source).

kou added 2 commits January 14, 2014 22:26
We need racc gem when any generated file by racc doesn't exist or any
generated file by racc is older than racc source file.
We need to run "rake check_extra_deps" before "rake newb" because we
can't find racc gem installed by "rake newb" in the same process.
@zzak
Copy link
Member

zzak commented Jan 28, 2014

Where is racc gem required? It's apart of stdlib I thought?

@drbrain
Copy link
Member

drbrain commented Jan 28, 2014

The runtime is, bin/racc is not

@zzak
Copy link
Member

zzak commented Jan 28, 2014

So I've opened Bug #9456 on Ruby to discuss including bin/racc in Ruby, however this change depends on modifying the license of the binary from GPL.

Also, since this change potentially wouldn't be released until Ruby 2.2, we should still consider @kou's patch as we should maintain backwards compatibility in RDoc.

drbrain added a commit that referenced this pull request Feb 3, 2014
@drbrain drbrain merged commit 006524c into ruby:master Feb 3, 2014
drbrain added a commit that referenced this pull request Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants