Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP-10148 Add worker parameters #25

Merged
merged 2 commits into from
Jul 17, 2020
Merged

NEP-10148 Add worker parameters #25

merged 2 commits into from
Jul 17, 2020

Conversation

andrba
Copy link
Contributor

@andrba andrba commented Jul 16, 2020

This PR adds support for additional parameters that can be passed to Patches::Worker.perform_async. This will allow the gem to be forward and backward compatible with the changes to the Patches::Worker in the upcoming releases.

CHANGELOG.md Outdated

## [3.0.1] - 2018-11-19
## [3.1.0] - 2018-11-19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change history 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything a 3.1.0 section needs to be added. And it looks like we never tagged these releases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right, thanks for pointing out. I was confused by the version number 👍

@andrba andrba merged commit f44c285 into develop Jul 17, 2020
@andrba andrba deleted the NEP-10148-worker-params branch July 17, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants