NEP-10148 Application version check #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntheticDave
approved these changes
Jul 17, 2020
| @@ -76,7 +93,7 @@ update the run method and then execute | |||
|
|
|||
| Generate patch with specs | |||
|
|
|||
| ``` | |||
| ```bash | |||
There was a problem hiding this comment.
✨ Nice touch adding the languages
msxavi
approved these changes
Jul 17, 2020
SyntheticDave
approved these changes
Jul 17, 2020
andrba
force-pushed
the
NEP-10148-application-version
branch
from
9bc3316
to
c50aabb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In environments where a rolling update of sidekiq workers is performed during the deployment, multiple versions of the application run at the same time. If a Patches job is scheduled by the new application version during the rolling update, there is a possibility that it can be executed by the old application version, which will not have all the required patch files.
This PR introduces an application version check. If an old application picks up the job and application versions don't match, the job is rescheduled in Sidekiq.