fix: plugin logging #139
Merged
fix: plugin logging #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aether-docs canceled.
|
Spazzy757
force-pushed
the
fix-add-better-plugin-logging
branch
from
5aca204
to
b6f3049
Compare
gabibeyer
approved these changes
May 29, 2024
Spazzy757
force-pushed
the
fix-add-better-plugin-logging
branch
from
b6f3049
to
780cede
Compare
With go-plugin it is hard to debug the plugins, therefore this change should allow for more robust logging. We should in the future make this more confiurable and aligined with the internal logging system Signed-off-by: Spazzy <brendankamp757@gmail.com>
Spazzy757
force-pushed
the
fix-add-better-plugin-logging
branch
from
9a40aac
to
5498b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With go-plugin it is hard to debug the plugins, therefore this change should allow for more robust logging. We should in the future make this more confiurable and aligined with the internal logging system