-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creates a plugin system #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spazzy757
force-pushed
the
plugin-system
branch
7 times, most recently
from
April 8, 2024 08:12
3782279
to
6a1fb82
Compare
Spazzy757
commented
Apr 8, 2024
Spazzy757
force-pushed
the
plugin-system
branch
3 times, most recently
from
April 8, 2024 09:41
eb20804
to
a2711f6
Compare
Spazzy757
force-pushed
the
plugin-system
branch
3 times, most recently
from
April 8, 2024 12:59
6083f7b
to
decfbbe
Compare
gabibeyer
reviewed
Apr 8, 2024
gabibeyer
reviewed
Apr 8, 2024
gabibeyer
reviewed
Apr 8, 2024
gabibeyer
reviewed
Apr 8, 2024
gabibeyer
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the converter test. This is awesome 🔥
Made a couple comments, but looks great
This is based on hashicorps go-plugin library using RPC calls to send an instance to a plugin all plugins in a specific directory that adhere to the interface laid out in `pkg/plugin/exporter.go` will be loaded on start up and when the event of `EmissionsCalculated` is received it will send the data to that plugin Signed-off-by: Spazzy <brendankamp757@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on hashicorps go-plugin library
using RPC calls to send an instance to a plugin
all plugins in a specific directory that adhere to the interface laid out in
pkg/plugin/exporter.go
will be loaded on start up and when the event ofEmissionsCalculated
is received it will send the data to that pluginfixes: #66