Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creates a plugin system #67

Merged
merged 1 commit into from
Apr 9, 2024
Merged

feat: creates a plugin system #67

merged 1 commit into from
Apr 9, 2024

Conversation

Spazzy757
Copy link
Contributor

@Spazzy757 Spazzy757 commented Apr 4, 2024

This is based on hashicorps go-plugin library
using RPC calls to send an instance to a plugin

all plugins in a specific directory that adhere to the interface laid out in pkg/plugin/exporter.go will be loaded on start up and when the event of EmissionsCalculated is received it will send the data to that plugin

fixes: #66

@Spazzy757 Spazzy757 marked this pull request as draft April 4, 2024 13:40
@Spazzy757 Spazzy757 force-pushed the plugin-system branch 7 times, most recently from 3782279 to 6a1fb82 Compare April 8, 2024 08:12
pkg/plugin/exporter.go Outdated Show resolved Hide resolved
@Spazzy757 Spazzy757 force-pushed the plugin-system branch 3 times, most recently from eb20804 to a2711f6 Compare April 8, 2024 09:41
@Spazzy757 Spazzy757 requested a review from gabibeyer April 8, 2024 09:41
@Spazzy757 Spazzy757 marked this pull request as ready for review April 8, 2024 09:41
@Spazzy757 Spazzy757 force-pushed the plugin-system branch 3 times, most recently from 6083f7b to decfbbe Compare April 8, 2024 12:59
Copy link
Contributor

@gabibeyer gabibeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the converter test. This is awesome 🔥

Made a couple comments, but looks great

@Spazzy757 Spazzy757 added the enhancement New feature or request label Apr 9, 2024
This is based on hashicorps go-plugin library
using RPC calls to send an instance to a plugin

all plugins in a specific directory that adhere to the interface laid
out in `pkg/plugin/exporter.go` will be loaded on start up and when the
event of `EmissionsCalculated` is received it will send the data to that
plugin

Signed-off-by: Spazzy <brendankamp757@gmail.com>
@Spazzy757 Spazzy757 merged commit b029c42 into main Apr 9, 2024
3 checks passed
@Spazzy757 Spazzy757 deleted the plugin-system branch April 9, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: exporter plugin system
2 participants