Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add boolean and boolean metrics #118

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

suelai
Copy link
Contributor

@suelai suelai commented Oct 17, 2023

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

Get counts of TRUE and FALSE for boolean values. Right now the column type are text and numeric only
change the macros that detect the column types for BigQuery to recognise booleans and add two metrics of count_true and count_false

How

Describe the solution

Add an if condition to bigquery__get_column_type to include the boolean column type. Add two metrics of count_trueandcount_false`

relates to re-data/re-data#405

@davidzajac1
Copy link
Collaborator

@suelai thanks for all the contributions! Made a small change on this one to make it work for all the other adapters.

@davidzajac1 davidzajac1 merged commit 2f8ce22 into re-data:main Nov 23, 2023
@suelai
Copy link
Contributor Author

suelai commented Nov 23, 2023

@suelai thanks for all the contributions! Made a small change on this one to make it work for all the other adapters.

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants