Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix react-dom imports #74

Merged
merged 1 commit into from
Oct 5, 2018

Commits on Oct 4, 2018

  1. fix react-dom imports

    react-dom does not use named exports and when rollup attempts to bundle
    these files it gives the following error:
    
    ```
    [!] Error: 'render' is not exported by ../../node_modules/react-dom/index.js
    https://github.com/rollup/rollup/wiki/Troubleshooting#name-is-not-exported-by-module
    node_modules/@reach/alert/es/index.js (19:9)
    17:
    18: import React from "react";
    19: import { render } from "react-dom";
                 ^
    20: import Component from "@reach/component-component";
    21: import VisuallyHidden from "@reach/visually-hidden";
    ```
    Kent C. Dodds committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    bb809d1 View commit details
    Browse the repository at this point in the history