#3047 Range input and allow for custom prop for select and range input #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 9, 2020 11:33
taion
approved these changes
Mar 9, 2020
Co-Authored-By: Jimmy Jia <tesrin@gmail.com>
jquense
approved these changes
Mar 10, 2020
Co-Authored-By: Jason Quense <monastic.panic@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Range input to Form.Control.
It also adds the custom prop to Form.Control and is usable if type is set to range or if as is set to select. It also handles sizing of the select element if custom is set.
It has added tests as well as updated documentation.