Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose maxLength #771

Merged
merged 8 commits into from
Jun 7, 2022
Merged

fix: expose maxLength #771

merged 8 commits into from
Jun 7, 2022

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jun 6, 2022

@vercel
Copy link

vercel bot commented Jun 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
select ✅ Ready (Inspect) Visit Preview Jun 7, 2022 at 7:01AM (UTC)

@MadCcc MadCcc changed the title fix: expose maxLength and raise customInputElement maxLength priotiry fix: expose maxLength and raise customInputElement maxLength priority Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #771 (8685a99) into master (446dd09) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   99.50%   99.51%           
=======================================
  Files          25       25           
  Lines        1020     1021    +1     
  Branches      341      338    -3     
=======================================
+ Hits         1015     1016    +1     
  Misses          4        4           
  Partials        1        1           
Impacted Files Coverage Δ
src/BaseSelect.tsx 100.00% <ø> (ø)
src/Selector/index.tsx 100.00% <ø> (ø)
src/Selector/Input.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@zombieJ
Copy link
Member

zombieJ commented Jun 7, 2022

我如果 HOC一个带 maxLength 的 input,你这个是抓不到的

@zombieJ
Copy link
Member

zombieJ commented Jun 7, 2022

我建议还是用户直接在 AutoComplete 上做 maxLength:

<AutoComplete maxLength={11}><input /></AutoComplete>

@MadCcc MadCcc changed the title fix: expose maxLength and raise customInputElement maxLength priority fix: expose maxLength Jun 7, 2022
@MadCcc MadCcc merged commit e97c5ab into master Jun 7, 2022
@MadCcc MadCcc deleted the fix/maxlength branch June 7, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete中自定义的Input中的maxLength props不生效
3 participants