为antd的editable-card类型的TabPane增加不可删除属性 #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
部分 TabPane 可以删除，部分不可以并且不显示删除按钮，需要和antd的PR一起实现
benjycui
reviewed
Feb 7, 2017
src/TabBarMixin.js
Outdated
| @@ -36,6 +36,9 @@ export default { | |||
| onClick: this.onTabClick.bind(this, key), | |||
| }; | |||
| } | |||
| if (child.props.closeable === false) { | |||
|
@afc163 这个没问题的话，合了发布下吧~ |
|
rc-tabs 没有 closeable 属性，加到这里不合适。应该把这个 className 加到这里去：https://github.com/ant-design/ant-design/pull/4807/files#diff-890204a57095a79c1c4b0bf626932b30L104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
部分 TabPane 可以删除，部分不可以并且不显示删除按钮，需要和antd的PR一起实现