Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event to onChange and onAmPmChange #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stas-Buzunko
Copy link

when time-picker is used with react-bootstrap Modals / Popovers / Overlays and you click on time it makes Modals / Popovers / Overlays close because this event happens outside container

the only way to control this by passing event so that it can't be prevented / stopped.
Some people in issues said they need to modify event for some reasons

#173
#92

feel free to modify pr as i've done it quickly for my own needs.

@vercel
Copy link

vercel bot commented Feb 17, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/time-picker/khumntal6
✅ Preview: https://time-picker-git-fork-stas-buzunko-master.react-component.now.sh

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #189 (1250795) into master (0217d69) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1250795 differs from pull request most recent head b3feba6. Consider uploading reports for the commit b3feba6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files           6        6           
  Lines         381      381           
  Branches       99       99           
=======================================
  Hits          350      350           
  Misses         31       31           
Impacted Files Coverage Δ
src/Combobox.jsx 93.58% <100.00%> (ø)
src/Panel.jsx 91.52% <100.00%> (ø)
src/Select.jsx 90.00% <100.00%> (ø)
src/TimePicker.jsx 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0217d69...b3feba6. Read the comment docs.

@gr8temi
Copy link

gr8temi commented Jun 10, 2020

Please why as this not been merged and to master for release. This feature is needed

@agonqorolli
Copy link

Will this PR be merged to master soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants