fix(class-validator): return instance unless rawValues is set #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisre
reviewed
Aug 17, 2023
|
|
||
| const result = await classValidatorResolver(SchemaTest, { | ||
| transformer: { | ||
| excludeExtraneousValues: true, |
There was a problem hiding this comment.
I don't find any documentation about excludeExtraneousValues and extraneousField. Do you have a link that explains these options?
There was a problem hiding this comment.
Sure! Here it's explained: https://github.com/typestack/class-transformer#enforcing-type-safe-instance
This was just to make sure that the class-transformer acted correctly and didn't send extra fields, but we could use any other use case for the test if necessary (like the example in the codesandbox linked in the issue)
jorisre
approved these changes
Aug 17, 2023
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR regarding this issue: #616