Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Windows - Backslashes is the escape #133

Closed
wants to merge 1 commit into from

Conversation

misaku
Copy link

@misaku misaku commented Jan 28, 2019

Summary:

Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle
issue:23176
i found this fix in past commit (0.57) and i submit again.

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Changelog:

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Test Plan:

in windows run react-native link and start error, Backslashes is the escape character and will result in an invalid path in settings.gradle

Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle
  [issue:23176]( facebook/react-native#23176)
  i found this fix in past commit (0.57) and i submit again.

Changelog:
----------

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Test Plan:
----------

in windows run react-native link and start error,  Backslashes is the escape character and will result in an invalid path in settings.gradle
@thymikee
Copy link
Member

Hey @misaku, thanks for the PR, but this issue is already handled by this diff: #130.

Please check if it resolves the problem for you and leave a comment there.

@thymikee thymikee closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants