feat: only show --verbose flag if there are hidden logs #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently always show details about this flag. The change will only log this message if there are debug log messages an the user is not in --verbose mode.
adamTrz
approved these changes
May 11, 2023
thymikee
pushed a commit
that referenced
this pull request
May 16, 2023
We currently always show details about this flag. The change will only log this message if there are debug log messages an the user is not in --verbose mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We currently always show details about this flag when there is some kind of error. The change will only log this message if there are
debuglog messages when the user has not enabled--verbosemode.I threw some example
logger.debugtext as an example:Test Plan:
Build and executed in my local environment.