[Android] Prepare auto-linking for double publishing #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
force-pushed
the
cipolleschi/support_new_arch_enabled_from_version
branch
from
892eefc
to
b4c4242
Compare
cipolleschi
force-pushed
the
cipolleschi/support_new_arch_enabled_from_version
branch
from
b4c4242
to
9462af6
Compare
cipolleschi
deleted the
cipolleschi/support_new_arch_enabled_from_version
branch
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: f22b912f67bc67d4b0b544371b1c334a92892666
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 55f324ac4dec0e23af8b231bb85703d9e53d95e0
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 010c735b77c6bcbff5b442d1a454571209738c5d
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 0a829d3aa75ecd7fb45c1f40b03f5a959744f92e
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 1dca14650a2a4de5b7d7caaa4043bb80845436d5
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: #39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 5164a1ddd26f1822c0d717a7a9e2416ec38d78a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With this change, we are preparing the CLI to support double publishing of React Native.
This change should be transparent to our users until we set up a version of React Native that is different from 0.X.Y
Test Plan:
Tested the code with RNTester.
Checklist