Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not have empty AUTOLINKED_LIBRARIES #2306

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

cortinico
Copy link
Member

Summary:

When working on TM CXX Autolinking I forgot to return the value here, and this results in AUTOLINKED_LIBRARIES CMake variable being empty. Effectively we're not linking against anything then, which is causing build failures in OSS.
See:

Test Plan:

Tested against RNTA reporducer by @tido64

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@cortinico
Copy link
Member Author

@thymikee @szymonrybczak we would need a CLI bump on the 0.74 release branch for this one (+ the fix should also be on main).

@thymikee thymikee merged commit 793ca14 into main Feb 22, 2024
10 checks passed
@thymikee thymikee deleted the nc/fix-autolinking branch February 22, 2024 16:23
@thymikee
Copy link
Member

Published v13.6.1 with this fix. Will make a major bump for the main branch later on

@WoLewicki
Copy link
Contributor

Hey, I just spent about 4 hours trying to make react-native-screens compile on new arch on 0.74.0-rc.0 just to find out that this was the problem 😅

@cortinico
Copy link
Member Author

Hey, I just spent about 4 hours trying to make react-native-screens compile on new arch on 0.74.0-rc.0 just to find out that this was the problem 😅

Sorry :'(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants