feat: RFC-0759 break apart iOS auto-linking #2335
Conversation
Instead of native_modules serving `use_native_modules!(config)`, users should now use `autolink_native_modules!()` from autolinking.rb. This is being used in react-native-community/template#7
blakef
changed the title
| # 15.0.0-alpha.1 (2024-03-15) | ||
|
|
||
| feat: added autolinking.rb, which breaks up use_native_modules! into list_native_modules!, and link_native_modules! (which lives in react-native). |
There was a problem hiding this comment.
I'm unusre we're actually using this CHANGELOG file 🤔
There was a problem hiding this comment.
True, we're not adding CHANGELOG inside this repo.
| # You should be using this instead of use_native_modules, which is deprecated. | ||
| def autolink_native_modules!() | ||
| link_native_modules! list_native_modules!() | ||
| end |
There was a problem hiding this comment.
Can we achieve the same without having to go through a deprecation cycle but by just changing the import path for the use_native_modules function?
There was a problem hiding this comment.
I spoke with @cipolleschi about the design, and I've leaning towards what you've described: keep the use_native_modules API to avoid a deprecation cycle / effort from our users.
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
TMisiukiewicz
added
no-stale-bot
|
Closing this as we went in another direction, where autolinking is inlined in react-native core, which is currently being used by the template. |
Summary:
Instead of native_modules serving
use_native_modules!(config), users should now useautolink_native_modules!()from autolinking.rb.This is being used in react-native-community/template#7
Warning
This needs to wait for nightlies to land with the updated TypeScript definitions, expect CI to fail until then.
Test Plan:
Checklist