Skip to content
This repository was archived by the owner on Jun 16, 2023. It is now read-only.

Commit 41079d5

Browse files
cozmon1ru4l
authored andcommitted
fix(ios): select correct capture session preset when defaultVideoQuality is not provided (#1908)
Closes #1900
1 parent 4f3e4f1 commit 41079d5

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

ios/RN/RNCamera.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
@property (nonatomic, assign) BOOL canReadText;
4444
@property(assign, nonatomic) AVVideoCodecType videoCodecType;
4545
@property (assign, nonatomic) AVCaptureVideoStabilizationMode videoStabilizationMode;
46-
@property(assign, nonatomic) NSInteger defaultVideoQuality;
46+
@property(assign, nonatomic, nullable) NSNumber *defaultVideoQuality;
4747

4848
- (id)initWithBridge:(RCTBridge *)bridge;
4949
- (void)updateType;

ios/RN/RNCamera.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,9 @@ - (void)startSession
605605
return;
606606
}
607607

608-
AVCaptureSessionPreset preset = [RNCameraUtils captureSessionPresetForVideoResolution:[self defaultVideoQuality]];
608+
// Default video quality AVCaptureSessionPresetHigh if non is provided
609+
AVCaptureSessionPreset preset = ([self defaultVideoQuality]) ? [RNCameraUtils captureSessionPresetForVideoResolution:[[self defaultVideoQuality] integerValue]] : AVCaptureSessionPresetHigh;
610+
609611
self.session.sessionPreset = preset == AVCaptureSessionPresetHigh ? AVCaptureSessionPresetPhoto: preset;
610612

611613
AVCaptureStillImageOutput *stillImageOutput = [[AVCaptureStillImageOutput alloc] init];

ios/RN/RNCameraManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ + (NSDictionary *)faceDetectorConstants
246246

247247
RCT_CUSTOM_VIEW_PROPERTY(defaultVideoQuality, NSInteger, RNCamera)
248248
{
249-
[view setDefaultVideoQuality:(NSInteger) [RCTConvert NSInteger:json]];
249+
[view setDefaultVideoQuality: [NSNumber numberWithInteger:[RCTConvert NSInteger:json]]];
250250
}
251251

252252
RCT_REMAP_METHOD(takePicture,

0 commit comments

Comments
 (0)