-
-
Notifications
You must be signed in to change notification settings - Fork 5k
android google map callout support <Image/> #3035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Any ETA on when this will be tested/merged? |
I'm still waiting for it too. Don't know why it had taken a long time |
Same issue, fix works for me, why it was not merged ? |
why this is nor merge yet? |
If it works, why it not merged? Please, merge it! |
please merge! |
MERGE it please !!! 👍 👍 👍 👍 👍 |
Does this repo need help with maintainers? |
@johnhaup any help is more than welcome :) |
LGTM @christopherdro @alvelig 🐽 |
Pls merge! Thank you |
* android google map callout support <Image/> * fix eslint error
Thank you for merging, however, I pulled the latest and it's still not working for me, am i missing something? Is anyone else getting the same issue still? 🐛 Bug ReportPackage version0.26.1 Steps to ReproduceAdd an Image component within the Callout component, and it's failing to render, only fails to render for Android, iOS works fine. Expected BehaviorThat the image renders in both Android and iOS Actual BehaviorImage does not render in Android Reproducible Demo |
This reverts commit 27c0e60.
These changes have been reverted. Please see discussion in #3035 |
@christopherdro why these changes were reverted? In my case the image issue on Android was solved in 0.27.0. |
@piotrgomola It's possible the fix worked for some, but as for @DanLeCornu and I it did not. For the meantime I had to resort to doing the Text wrapper fix. Hoping a consistent fix gets added in though, current workarounds are less than ideal. |
You may need add this prop 'tracksViewChanges={true}' |
I tested it and it works fine, you may need to add this configuration 'tracksViewChanges={true}' |
@dkleikesa thanks! will test it out asap |
I tried https://github.com/dragma/react-native-maps.git#BOUYA and version 0.27.1 and Image is still not showing on Android. Also Text wrapping was not working for me. Can someone help on this one? |
Okay, wrapping with Text was not working because of flex, now I managed to fix it with static width and height, but it would be good if this is fixed and Image is supported. |
* android google map callout support <Image/> * fix eslint error
* android google map callout support <Image/> * fix eslint error
…s#3035)" (react-native-maps#3351) This reverts commit 27c0e60.
Does any other open PR do the same thing?
NO
What issue is this PR fixing?
#2633
How did you test this PR?
Use the example page [Arbitrary Views as Markers] , wait a little time, and tap the bear marker