Skip to content

Conversation

dkleikesa
Copy link
Contributor

Does any other open PR do the same thing?

NO

What issue is this PR fixing?

#2633

How did you test this PR?

Use the example page [Arbitrary Views as Markers] , wait a little time, and tap the bear marker

@orhan
Copy link

orhan commented Dec 9, 2019

Any ETA on when this will be tested/merged?
Can I help with something to fasten up the process?

@thanhluantl2304
Copy link

Any ETA on when this will be tested/merged?
Can I help with something to fasten up the process?

I'm still waiting for it too. Don't know why it had taken a long time

jeremybviseo added a commit to jeremybviseo/react-native-maps-fixed that referenced this pull request Jan 10, 2020
@jeremybviseo
Copy link

Same issue, fix works for me, why it was not merged ?

@Eramirez06
Copy link

why this is nor merge yet?

@esafev
Copy link

esafev commented Feb 4, 2020

If it works, why it not merged? Please, merge it!

@DanLeCornu
Copy link

please merge!

@amsimoes
Copy link

amsimoes commented Feb 6, 2020

MERGE it please !!! 👍 👍 👍 👍 👍

@johnhaup
Copy link

Does this repo need help with maintainers?

@rborn
Copy link
Collaborator

rborn commented Feb 26, 2020

@johnhaup any help is more than welcome :)

@rborn
Copy link
Collaborator

rborn commented Feb 26, 2020

LGTM @christopherdro @alvelig 🐽

@AndreBordignon
Copy link

Pls merge! Thank you

@christopherdro christopherdro merged commit 93ac791 into react-native-maps:master Feb 27, 2020
lumenlunae pushed a commit to lumenlunae/react-native-maps that referenced this pull request Feb 29, 2020
* android google map callout support <Image/>

* fix eslint error
@DanLeCornu
Copy link

Thank you for merging, however, I pulled the latest and it's still not working for me, am i missing something? Is anyone else getting the same issue still?

🐛 Bug Report

Package version

0.26.1

Steps to Reproduce

Add an Image component within the Callout component, and it's failing to render, only fails to render for Android, iOS works fine.

Expected Behavior

That the image renders in both Android and iOS

Actual Behavior

Image does not render in Android

Reproducible Demo

https://snack.expo.io/HJFqIAsVU

@christopherdro
Copy link
Collaborator

christopherdro commented Mar 19, 2020

These changes have been reverted. Please see discussion in #3035
@dkleikesa Can you take a look?

christopherdro added a commit that referenced this pull request Mar 19, 2020
@piotrgomola
Copy link

@christopherdro why these changes were reverted?

In my case the image issue on Android was solved in 0.27.0.

@rpadilla6
Copy link

@piotrgomola It's possible the fix worked for some, but as for @DanLeCornu and I it did not. For the meantime I had to resort to doing the Text wrapper fix. Hoping a consistent fix gets added in though, current workarounds are less than ideal.

@dkleikesa
Copy link
Contributor Author

Thank you for merging, however, I pulled the latest and it's still not working for me, am i missing something? Is anyone else getting the same issue still?

🐛 Bug Report

Package version

0.26.1

Steps to Reproduce

Add an Image component within the Callout component, and it's failing to render, only fails to render for Android, iOS works fine.

Expected Behavior

That the image renders in both Android and iOS

Actual Behavior

Image does not render in Android

Reproducible Demo

https://snack.expo.io/HJFqIAsVU

You may need add this prop 'tracksViewChanges={true}'

@dkleikesa
Copy link
Contributor Author

These changes have been reverted. Please see discussion in #3035
@dkleikesa Can you take a look?

I tested it and it works fine, you may need to add this configuration 'tracksViewChanges={true}'

@DanLeCornu
Copy link

DanLeCornu commented May 3, 2020

@dkleikesa thanks! will test it out asap

@ilchoTaleski
Copy link

I tried https://github.com/dragma/react-native-maps.git#BOUYA and version 0.27.1 and Image is still not showing on Android. Also Text wrapping was not working for me. Can someone help on this one?

@ilchoTaleski
Copy link

I tried https://github.com/dragma/react-native-maps.git#BOUYA and version 0.27.1 and Image is still not showing on Android. Also Text wrapping was not working for me. Can someone help on this one?

Okay, wrapping with Text was not working because of flex, now I managed to fix it with static width and height, but it would be good if this is fixed and Image is supported.

pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
* android google map callout support <Image/>

* fix eslint error
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
* android google map callout support <Image/>

* fix eslint error
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.