feat: focus events management on Android picker #258

mateusz1913 · 2021-05-04T20:37:22Z

Hi, I want to introduce two features for Android picker in that PR

Focus events onBlur and onFocus
Possibility of programmatic opening/closing of picker

I updated README and example app with example usage of these new features.

Closes #54 #204 #205 #256
and I guess that it should also be ok for #170

Lucas-Alvino · 2021-05-10T18:48:03Z

This PR would be very useful

Lucas-Alvino · 2021-05-10T18:58:47Z

@Naturalclar merge plis

Lucas-Alvino · 2021-05-11T16:52:52Z

@Naturalclar merge plis

Naturalclar · 2021-05-11T17:09:54Z

js/Picker.js

@@ -133,6 +133,7 @@ type PickerProps = $ReadOnly<{|
 *     </Picker>
 */
 class Picker extends React.Component<PickerProps> {
+  pickerRef = React.createRef();


Suggested change

pickerRef = React.createRef();

pickerRef: React.ElementRef<any> = React.createRef();

Naturalclar · 2021-05-11T17:10:22Z

js/Picker.js

+  blur = () => {
+    this.pickerRef.current?.blur();
+  };


Suggested change

blur = () => {

this.pickerRef.current?.blur();

};

blur: () => void = () => {

this.pickerRef.current?.blur();

};

Naturalclar · 2021-05-11T17:10:31Z

js/Picker.js

+    this.pickerRef.current?.blur();
+  };
+
+  focus = () => {


Suggested change

focus = () => {

focus: () => void = () => {

Naturalclar

@mateusz1913 thanks for the addition!
there are some FlowType errors that is making the CI fail.
Could you check the places I've commented?

mateusz1913 · 2021-05-11T17:38:33Z

Done

Naturalclar

LGTM! thank you so much! 🎉

# [1.16.0](v1.15.0...v1.16.0) (2021-05-11) ### Features * focus events management on Android picker ([#258](#258)) ([58ad784](58ad784))

Naturalclar · 2021-05-11T17:57:41Z

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

trandinhduc90 · 2021-06-13T13:36:31Z

Hi @mateusz1913 I got a problem with CI build because the ReactPickerManager.java file has two functions receiveCommand with two @Override Android will build failed

mateusz1913 · 2021-06-13T13:47:11Z

Hi @trandinhduc90, without any kind of logs or some error feedback I am not able to help

trandinhduc90 · 2021-06-13T13:49:47Z

Hi @trandinhduc90, without any kind of logs or some error feedback I am not able to help

Task :@react-native-picker_picker:compileReleaseJavaWithJavac FAILED /Users/runner/work/1/s/node_modules/@react-native-picker/picker/android/src/main/java/com/reactnativecommunity/picker/ReactPickerManager.java:161: error: method does not override or implement a method from a supertype @Override

This is error when I run CI build

mateusz1913 · 2021-06-13T14:28:46Z

So it seems that you have some RN old version. Take a look here (these methods in base class): ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java in react-native repo (lines 201 and 212)

Method with int argument is deprecated (at least for newer RN versions). From your error it seems that there is sth wrong with new receiveCommand override (that one with String argument)

What RN version do you use?

trandinhduc90 · 2021-06-13T14:59:52Z

So it seems that you have some RN old version. Take a look here (these methods in base class): ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java in react-native repo (lines 201 and 212)

Method with int argument is deprecated (at least for newer RN versions). From your error it seems that there is sth wrong with new receiveCommand override (that one with String argument)

What RN version do you use?

I guess that about my react-native version. Currently, I'm using 0.60.5 so maybe I will try to upgrade my react-native version to 0.63 and gave you feedback soon. So thanks for the reply.

mateusz1913 · 2021-06-13T15:10:02Z

facebook/react-native@3cae6fa

facebook/react-native@6eec393

These are commits that included second receiveCommand override and deprecated first one

They are included on 0.61+ branches, so you definitely need to upgrade to at least 0.61

@Naturalclar maybe percentage of devs using old RN versions is low, but it would be good to add small note in README, that focus management is available from 0.61+, if I'll have time I can make it, but maybe someone will be quicker

trandinhduc90 · 2021-06-13T15:15:23Z

facebook/react-native@3cae6fa

facebook/react-native@6eec393

These are commits that included second receiveCommand override and deprecated first one

They are included on 0.61+ branches, so you definitely need to upgrade to at least 0.61

@Naturalclar maybe percentage of devs using old RN versions is low, but it would be good to add small note in README, that focus management is available from 0.61+, if I'll have time I can make it, but maybe someone will be quicker

Thanks @mateusz1913 , I will try to upgrade to 0.61. So some company still using old react-native version because there don't has the resource to maintain there app.

omaryoussef · 2021-06-19T18:33:52Z

I don't know if anyone is still looking at this PR, but using a ref to execute the focus method comes back with an error pickerRef$current.focus is not a function. Any workarounds? It seems like it's not just me: #276

mateusz1913 requested a review from Naturalclar as a code owner May 4, 2021 20:37

Gitarcitano approved these changes May 10, 2021

View reviewed changes

Lucas-Alvino approved these changes May 10, 2021

View reviewed changes

Naturalclar reviewed May 11, 2021

View reviewed changes

Naturalclar requested changes May 11, 2021

View reviewed changes

feat(react-native-picker#54): focus events management on Android picker

4dd9b9b

mateusz1913 force-pushed the feat/54-focus-events branch from 0aa95de to 4dd9b9b Compare May 11, 2021 17:38

Naturalclar approved these changes May 11, 2021

View reviewed changes

Naturalclar changed the title ~~feat(#54): focus events management on Android picker~~ feat: focus events management on Android picker May 11, 2021

Naturalclar merged commit 58ad784 into react-native-picker:master May 11, 2021

github-actions bot pushed a commit that referenced this pull request May 11, 2021

chore(release): 1.16.0 [skip ci]

c6addc2

# [1.16.0](v1.15.0...v1.16.0) (2021-05-11) ### Features * focus events management on Android picker ([#258](#258)) ([58ad784](58ad784))

Naturalclar added the released label May 11, 2021

mateusz1913 deleted the feat/54-focus-events branch May 15, 2021 13:47

bacarybruno mentioned this pull request May 30, 2021

toggle not working in Android. lawnstarter/react-native-picker-select#424

Closed

mattmcardle mentioned this pull request Jun 4, 2021

follow the instructions, but pickerRef.current.focus is not a function... #276

Open

mateusz1913 mentioned this pull request Jun 22, 2021

fix: Focus and ref fixes #284

Merged

mpasalic mentioned this pull request Sep 27, 2021

Cannot call this.inputRefs.picker.togglePicker() on Android lawnstarter/react-native-picker-select#22

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: focus events management on Android picker #258

feat: focus events management on Android picker #258

mateusz1913 commented May 4, 2021

Lucas-Alvino commented May 10, 2021

Lucas-Alvino commented May 10, 2021

Lucas-Alvino commented May 11, 2021

Naturalclar May 11, 2021

Naturalclar May 11, 2021

Naturalclar May 11, 2021

Naturalclar left a comment

mateusz1913 commented May 11, 2021

Naturalclar left a comment

Naturalclar commented May 11, 2021

trandinhduc90 commented Jun 13, 2021

mateusz1913 commented Jun 13, 2021

trandinhduc90 commented Jun 13, 2021

mateusz1913 commented Jun 13, 2021 •

edited

Loading

trandinhduc90 commented Jun 13, 2021

mateusz1913 commented Jun 13, 2021 •

edited

Loading

trandinhduc90 commented Jun 13, 2021

omaryoussef commented Jun 19, 2021

	pickerRef = React.createRef();
	pickerRef: React.ElementRef<any> = React.createRef();

feat: focus events management on Android picker #258

feat: focus events management on Android picker #258

Conversation

mateusz1913 commented May 4, 2021

Lucas-Alvino commented May 10, 2021

Lucas-Alvino commented May 10, 2021

Lucas-Alvino commented May 11, 2021

Naturalclar May 11, 2021

Choose a reason for hiding this comment

Naturalclar May 11, 2021

Choose a reason for hiding this comment

Naturalclar May 11, 2021

Choose a reason for hiding this comment

Naturalclar left a comment

Choose a reason for hiding this comment

mateusz1913 commented May 11, 2021

Naturalclar left a comment

Choose a reason for hiding this comment

Naturalclar commented May 11, 2021

trandinhduc90 commented Jun 13, 2021

mateusz1913 commented Jun 13, 2021

trandinhduc90 commented Jun 13, 2021

mateusz1913 commented Jun 13, 2021 • edited Loading

trandinhduc90 commented Jun 13, 2021

mateusz1913 commented Jun 13, 2021 • edited Loading

trandinhduc90 commented Jun 13, 2021

omaryoussef commented Jun 19, 2021

mateusz1913 commented Jun 13, 2021 •

edited

Loading

mateusz1913 commented Jun 13, 2021 •

edited

Loading