Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper ES6 default export #39

Conversation

leonid-shevtsov
Copy link
Contributor

I was getting ESLint errors on the import statement for this package. (see rule documentation.)

Technically, to use the suggested import syntax:

import PushNotificationIOS from '@react-native-community/push-notification-ios';

the package should have an export default.

And since you are already using ES6 import statements, it won't harm compatibility.

Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants