fix: new NativeEventEmitter() was called with a non-null argument console warning #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a breaking change or just a warning? I'm trying to figure out why voice is not working. Edit for reference: not a breaking change that I could see, voice still worked despite the warning |
ErHarinderSingh
approved these changes
Dec 22, 2023
angusryer
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Can someone with write permissions approve this? (eg. @carlmagumpara I think, among several others)
Adding these methods resolves the related RN warnings. This is not a breaking change since it does not implement any functional code changes or modify dependencies.
GitPaulPark
approved these changes
Jan 15, 2024
|
NOTE: Anyone can review this PR, but in order for it to be merged automatically, we need the author or a contributor to review it. |
adriandt
approved these changes
Apr 1, 2024
danieljimeneznz
approved these changes
Apr 1, 2024
pedrol2b
approved these changes
Apr 4, 2024
AndersonVanzo
approved these changes
Jun 4, 2024
|
Please merge this changes. |
|
Can someone merge this? Or is this not maintained anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
addListenerandremoveListenersmethod to stop console warning about:Issue #455
reference