feat: add support for iframe and differing owner documents #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
force-pushed
the
window-context
branch
from
3b25e42 to
ff27187
Compare
kyletsang
approved these changes
Dec 7, 2021
src/ModalManager.ts
Outdated
| private state!: ContainerState; | ||
| protected state!: ContainerState; | ||
|
|
||
| protected ownerDocument: any; |
There was a problem hiding this comment.
Suggested change
| protected ownerDocument: any; | |
| protected ownerDocument: Document | undefined; |
src/useWindow.ts
Outdated
|
|
||
| const Context = createContext(canUseDOM ? window : undefined); | ||
|
|
||
| export const Provider = Context.Provider; |
There was a problem hiding this comment.
Should Provider be renamed to WindowProvider so consumers can avoid the import alias like in the example below?
Brendan-csel
added a commit
to solid-libs/solid-bootstrap
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things:
useWindowhook for accessing the currentwindowobject, which can be set in unique situations, such as rendering components into an iframe. Defaults the the globalwindowif availableuseWindowor if an element is present, their owner document/view