Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <optgroup> to the Select component (#395) #401

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

dacerondrej
Copy link
Contributor

@dacerondrej dacerondrej commented Aug 9, 2022

Closes #395

src/lib/components/SelectField/_components/index.js Outdated Show resolved Hide resolved
src/lib/components/SelectField/_components/index.js Outdated Show resolved Hide resolved
src/lib/components/SelectField/SelectField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/_components/OptionField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/_components/OptionField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/SelectField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/SelectField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/SelectField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/_components/OptionField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/SelectField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/SelectField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/_components/index.js Outdated Show resolved Hide resolved
src/lib/components/SelectField/SelectField.jsx Outdated Show resolved Hide resolved
Copy link
Member

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the updated docs too.

src/lib/components/SelectField/_components/OptionField.jsx Outdated Show resolved Hide resolved
src/lib/components/SelectField/_components/index.js Outdated Show resolved Hide resolved
src/lib/components/Radio/Radio.jsx Outdated Show resolved Hide resolved
src/lib/components/Radio/Radio.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@mbohal mbohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny detail in the docs, otherwise it looks great! 👍🏻

src/lib/components/SelectField/README.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for <optgroup> to the Select component
5 participants