bug fix: "Active" button not getting focused state #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afzalzbr there are some linting issues in CI |
|
@arturbien okay I'll check. |
afzalzbr
added a commit
to afzalzbr/React95
that referenced
this pull request
Apr 13, 2023
|
@arturbien fixed the linting issue, please review and approve. |
arturbien
requested changes
Apr 20, 2023
|
@arturbien yup, you are right. I removed it and it's working fine now. |
arturbien
previously approved these changes
Apr 21, 2023
|
@afzalzbr great! Now before I merge please squash all the commits into single commit with message:
|
bug fix: active button focus issue resolved removed !active flag from line 167. bug fix: "Active" button not getting focused state
afzalzbr
force-pushed
the
fix/#383_active-button-focus-style
branch
from
20e6e4c
to
9b92208
Compare
|
@arturbien done |
|
@afzalzbr your commit was merged to master. Thank you for the contribution <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
focusOutlinewas not including any case for active === true.I've made changes in the file:
src\Button\Button.tsx:Following is the working example of the fix for the 'Active' button, followed by a picture showing no other buttons' styles are being compromised:
I hope this helps!
Fixes #383