Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix components' props types #782

Merged
merged 2 commits into from
Oct 18, 2021
Merged

fix: fix components' props types #782

merged 2 commits into from
Oct 18, 2021

Conversation

dangreen
Copy link
Collaborator

fix #734, possible fix of #741

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #782 (1be5d56) into master (74c169a) will increase coverage by 20.95%.
The diff coverage is 40.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #782       +/-   ##
===========================================
+ Coverage   39.56%   60.52%   +20.95%     
===========================================
  Files           3        4        +1     
  Lines         139      152       +13     
  Branches       40       38        -2     
===========================================
+ Hits           55       92       +37     
+ Misses         72       39       -33     
- Partials       12       21        +9     
Impacted Files Coverage Δ
src/types.ts 0.00% <0.00%> (ø)
src/typedCharts.tsx 63.41% <33.33%> (ø)
src/chart.tsx 66.66% <42.10%> (-1.24%) ⬇️
src/index.tsx 41.37% <100.00%> (+41.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c169a...1be5d56. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 18, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.js 9.22 KB (+0.48% 🔺) 185 ms (+0.48% 🔺) 137 ms (-18.19% 🔽) 321 ms
dist/index.modern.js 9.2 KB (+0.53% 🔺) 185 ms (+0.53% 🔺) 128 ms (-54.2% 🔽) 312 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong TS type for plugins prop
2 participants