Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we create a product variant compareAtPrice is mandatory #320

Closed
3 tasks done
CristianCucunuba opened this issue Sep 12, 2020 · 0 comments · Fixed by #322
Closed
3 tasks done

When we create a product variant compareAtPrice is mandatory #320

CristianCucunuba opened this issue Sep 12, 2020 · 0 comments · Fixed by #322

Comments

@CristianCucunuba
Copy link
Contributor

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?
  • Did you search the issue queue for existing issue? Search issues

Issue Description

When we are creating a product variant we cannot set the price if the input for compareAtPrice is was focused before. The admin does not show any error it just don't update the price because the form validator fails. I think this is a bug because the compareAtPrice is supposed to be optional

Steps to Reproduce

  1. Go to products on the admin
  2. Create a new product and click to the variant
  3. Add only a price and dont touche the input or set a value for compare price and click save changes
    4.Refresh the page or check the DB and the variant price is not updated

Possible Solution

The form validator is missing the optional:true property for the compareAtPrice object

Versions

3.0.0-beta.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant