-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate aldeed:simple-schema and implement npm simpl-schema #2917
Comments
fwiw I played with this recently and the main issue I ran into was that |
I've gone ahead and replaced all instances of Current issues I'm running into: it appears that the node version does not support our
From @mikemurray, we need to be aware of how our Validation works with this. I've not looked into this at all yet. I've not had a chance to update Because the app crashes immediately, I can't consider this to be an entire list of issues we'll run into when completing the swap, but it's definitely a good start. For |
Related #3034 |
PR #3053 will be the registerSchema updates. It's working well as is with a few test schemas, just need to make sure all schemas are registered. |
@aaronjudd @spencern Let me know if you want me to tackle this and #3034. I'm going to try getting back into the reaction codebase a bit. |
@aldeed that'd be awesome! happy to have you. (added you back to collaborators to make life easy) |
Would love that @aldeed https://github.com/reactioncommerce/reaction/tree/spencer-node-simple-schema-update-schemas |
@spencern Thanks, I will start from there |
Deprecate https://github.com/aldeed/meteor-simple-schema and replace with https://github.com/aldeed/node-simple-schema
We've tested a few times and there were some issues, but it's time to revisit, as we need this in place for our react components to use for validation, and also in some new registry requirements we're working on. This would also allow us to deprecate meteor autoform as soon as the remaining dashboard blaze templates are converted.
The text was updated successfully, but these errors were encountered: