-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create standard coupon #6734
Conversation
|
e078c85
to
81961b1
Compare
Broken unit tests and broken DCO. Also, I think we should be moving coupon work into a separate feature branch so we can test the existing functionality separately. |
packages/api-plugin-promotions-coupons/src/mutations/createStandardCoupon.test.js
Outdated
Show resolved
Hide resolved
packages/api-plugin-promotions-coupons/src/mutations/createStandardCoupon.test.js
Show resolved
Hide resolved
Signed-off-by: vanpho93 <vanpho02@gmail.com>
742c2a8
to
e1e82a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the coupon referred to as Standard Coupon? Does that imply there are nonstandard coupons? If the collection name is just Coupon
do we need to overstate that it is a standard one?
Apart from that the PR looks good.
@tedraykov a standard coupon does not require userId so it can be applied by anyone. |
This can't be implied from the naming alone, but I haven't seen the full specs for the coupons so I'll take it as is. |
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
The base branch was changed.
…pon-mutation feat: improve apply coupon mutation
…-from-cart-mutation feat: remove coupon from cart mutation
Resolves #6723
Impact: major
Type: feature
Solution
Creating the mutation allows the admin can create a standard coupon.