Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create standard coupon #6734

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Conversation

vanpho93
Copy link
Member

Resolves #6723
Impact: major
Type: feature

Solution

Creating the mutation allows the admin can create a standard coupon.

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

⚠️ No Changeset found

Latest commit: 13b876e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vanpho93 vanpho93 changed the base branch from trunk to feat/promotions December 29, 2022 08:20
@vanpho93 vanpho93 force-pushed the feat/create-standard-coupon branch 2 times, most recently from e078c85 to 81961b1 Compare December 29, 2022 08:46
@zenweasel
Copy link
Collaborator

Broken unit tests and broken DCO.

Also, I think we should be moving coupon work into a separate feature branch so we can test the existing functionality separately.

Signed-off-by: vanpho93 <vanpho02@gmail.com>
Copy link
Collaborator

@tedraykov tedraykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the coupon referred to as Standard Coupon? Does that imply there are nonstandard coupons? If the collection name is just Coupon do we need to overstate that it is a standard one?

Apart from that the PR looks good.

@vanpho93
Copy link
Member Author

vanpho93 commented Jan 9, 2023

Why is the coupon referred to as Standard Coupon? Does that imply there are nonstandard coupons? If the collection name is just Coupon do we need to overstate that it is a standard one?

@tedraykov a standard coupon does not require userId so it can be applied by anyone.

@tedraykov
Copy link
Collaborator

This can't be implied from the naming alone, but I haven't seen the full specs for the coupons so I'll take it as is.

tedraykov
tedraykov previously approved these changes Jan 18, 2023
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93 vanpho93 changed the base branch from feat/promotions to feat/coupons January 30, 2023 03:15
@vanpho93 vanpho93 dismissed stale reviews from tedraykov and zenweasel January 30, 2023 03:15

The base branch was changed.

…pon-mutation

feat: improve apply coupon mutation
…-from-cart-mutation

feat: remove coupon from cart mutation
@vanpho93 vanpho93 merged commit df9de17 into feat/coupons Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As an operator I want to create a Standard coupon
3 participants