Skip to content

Commit

Permalink
better logs for idom.run + flask server
Browse files Browse the repository at this point in the history
  • Loading branch information
rmorshea committed Mar 10, 2021
1 parent 9084467 commit 2b34e3d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/idom/log.py
Expand Up @@ -25,7 +25,7 @@
},
"formatters": {
"generic": {
"format": "%(asctime)s | %(levelname)s | %(name)s | %(message)s",
"format": "%(asctime)s | %(levelname)s | %(message)s",
"datefmt": r"%Y-%m-%dT%H:%M:%S%z",
"class": "logging.Formatter",
}
Expand Down
4 changes: 3 additions & 1 deletion src/idom/server/flask.py
Expand Up @@ -23,6 +23,8 @@

from .base import AbstractRenderServer

logger = logging.getLogger(__name__)


class Config(TypedDict, total=False):
"""Render server config for :class:`FlaskRenderServer`"""
Expand Down Expand Up @@ -163,7 +165,7 @@ def _generic_run_application(
) -> None:
if debug:
logging.basicConfig(level=logging.DEBUG) # coverage: skip
logging.debug("Starting server...")
logger.info(f"Running at http://{host}:{port}")
self._wsgi_server = _StartCallbackWSGIServer(
self._server_did_start.set,
(host, port),
Expand Down
8 changes: 5 additions & 3 deletions src/idom/server/prefab.py
@@ -1,3 +1,4 @@
import logging
from typing import Any, Dict, Optional, Tuple, Type, TypeVar

from idom.core.component import ComponentConstructor
Expand All @@ -6,12 +7,13 @@
from .base import AbstractRenderServer
from .utils import find_available_port, find_builtin_server_type

logger = logging.getLogger(__name__)
_S = TypeVar("_S", bound=AbstractRenderServer[Any, Any])


def run(
component: ComponentConstructor,
server_type: Optional[Type[_S]] = find_builtin_server_type("PerClientStateServer"),
server_type: Type[_S] = find_builtin_server_type("PerClientStateServer"),
host: str = "127.0.0.1",
port: Optional[int] = None,
server_config: Optional[Any] = None,
Expand Down Expand Up @@ -44,11 +46,11 @@ def run(
The server instance. This isn't really useful unless the server is spawned
as a daemon. Otherwise this function blocks until the server has stopped.
"""
if server_type is None: # coverage: skip
raise ValueError("No default server available.")
if port is None: # coverage: skip
port = find_available_port(host)

logger.info(f"Using {server_type.__module__}.{server_type.__name__}")

server = server_type(component, server_config)

if app is not None: # coverage: skip
Expand Down

0 comments on commit 2b34e3d

Please sign in to comment.