-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bypass jsonpatch #809
bypass jsonpatch #809
Conversation
5761211
to
2ea6094
Compare
How certain are we that the current exception ( |
I'm pretty certain. Could you test using this branch though to be sure? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not fix the issue on django-idom
, tested via pip install git+
I have a couple questions:
|
Branchreactive-python/reactpy-django#86 (idom-team/django-idom@use_database) Code SampleManually running the Error messageYes it is the same even when using this bypass jsonpatch branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working.
will release tomorrow |
The
jsonpatch
library is broken and it seems like there's no one to maintain it. We should just avoid JSON Patch entirely since, so long as you're careful about what components you re-render, diffing is not usually necessary. In a future release, the client will stop using JSON patch altogether.Checklist
Please update this checklist as you complete each item:
changelog.rst
has been updated with any significant changes.