Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypass jsonpatch #809

Merged
merged 1 commit into from
Sep 13, 2022
Merged

bypass jsonpatch #809

merged 1 commit into from
Sep 13, 2022

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Sep 13, 2022

The jsonpatch library is broken and it seems like there's no one to maintain it. We should just avoid JSON Patch entirely since, so long as you're careful about what components you re-render, diffing is not usually necessary. In a future release, the client will stop using JSON patch altogether.

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@Archmonger
Copy link
Contributor

How certain are we that the current exception (onChange missing) detected on reactive-python/reactpy-django#86 is related to Json patch?

@rmorshea
Copy link
Collaborator Author

I'm pretty certain. Could you test using this branch though to be sure? pip install git+https://github.com/idom-team/idom@bypass-jsonpatch

Copy link
Contributor

@Archmonger Archmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the issue on django-idom, tested via pip install git+

@rmorshea
Copy link
Collaborator Author

rmorshea commented Sep 13, 2022

I have a couple questions:

  • on what branch is this happening?
  • with what code sample?
  • is the error message the same?

@Archmonger
Copy link
Contributor

Archmonger commented Sep 13, 2022

Branch

reactive-python/reactpy-django#86 (idom-team/django-idom@use_database)

Code Sample

Manually running the use_mutation and use_database tests via python test/manage.py runserver and inspecting in browser

Error message

Yes it is the same even when using this bypass jsonpatch branch.

Copy link
Contributor

@Archmonger Archmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working.

@rmorshea rmorshea merged commit 7caa4ab into main Sep 13, 2022
@rmorshea rmorshea deleted the bypass-jsonpatch branch September 13, 2022 08:37
@rmorshea
Copy link
Collaborator Author

will release tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants