enhance: Infer returntype of useFetcher()'s functions #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 30.7 kB ℹ️ View Unchanged
|
ntucker
commented
Apr 1, 2020
| Params extends Readonly<object>, | ||
| S extends Schema | ||
| >(fetchShape: ReadShape<S, Params>, params: Params | null) { | ||
| export default function useRetrieve<Shape extends ReadShape<any, any>>( |
There was a problem hiding this comment.
parameter of Shape rather than a part gives us more information. this is used in useFetcher() which infers its return type
ntucker
force-pushed
the
useFetcher-return
branch
from
4b2a19d
to
abfd036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously it was just 'any', which is often not very helpful.
Solution
We'll grab from the fetch function as that's the simplest approach and most accurate.
Open questions