Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceList Overloads for MergeChangeSets for Cache ChangeSets #763

Merged

Conversation

dwcullop
Copy link
Member

@dwcullop dwcullop commented Nov 23, 2023

Description

Adds overloads for ISourceList to enable using MergeChangeSets for Cache Observable ChangeSets just like one can invoke similar to IEnumerable<IObservable<IChangeSet<TObject, TKey>>>`.

Just some syntactic sugar that I think would be helpful for some users to find the functionality.

It also supports IObservable<IChangeSet<IObservable<IChangeSet<TObject, TKey>>>> for list changesets of cache changesets.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 425 lines in your changes are missing coverage. Please review.

Comparison is base (53d5f6d) 64.74% compared to head (292fb8f) 65.80%.
Report is 7 commits behind head on main.

Files Patch % Lines
src/DynamicData/Cache/ObservableCacheEx.cs 53.48% 19 Missing and 1 partial ⚠️
src/DynamicData/List/ObservableListEx.cs 67.79% 16 Missing and 3 partials ⚠️
src/DynamicData/List/Internal/Transformer.cs 52.00% 9 Missing and 3 partials ⚠️
src/DynamicData/Aggregation/AvgEx.cs 73.68% 10 Missing ⚠️
src/DynamicData/Aggregation/SumEx.cs 74.35% 10 Missing ⚠️
src/DynamicData/ObservableChangeSet.cs 58.33% 10 Missing ⚠️
src/DynamicData/Platforms/net45/ParallelEx.cs 25.00% 7 Missing and 2 partials ⚠️
src/DynamicData/Aggregation/StdDevEx.cs 76.66% 5 Missing and 2 partials ⚠️
src/DynamicData/List/Internal/GroupOnProperty.cs 0.00% 7 Missing ⚠️
src/DynamicData/Aggregation/CountEx.cs 25.00% 6 Missing ⚠️
... and 127 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   64.74%   65.80%   +1.06%     
==========================================
  Files         226      228       +2     
  Lines       11459    11181     -278     
  Branches     2334     2307      -27     
==========================================
- Hits         7419     7358      -61     
+ Misses       3083     2884     -199     
+ Partials      957      939      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwcullop dwcullop enabled auto-merge (squash) November 23, 2023 19:05
@dwcullop dwcullop self-assigned this Nov 23, 2023
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dwcullop dwcullop merged commit f6eadfe into reactivemarbles:main Nov 23, 2023
5 checks passed
@dwcullop dwcullop deleted the feature/list-merge-cache-changesets branch November 25, 2023 21:41
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants