Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add bulk inserts for sqlite #499

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Aug 6, 2019

This fixes #470 and fixes #451

Change the SQL raw class to support IObjectBulkBlobCache interface. Implement the bulk insertions.

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #499 into master will increase coverage by 0.15%.
The diff coverage is 70.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   54.61%   54.77%   +0.15%     
==========================================
  Files          57       57              
  Lines        3444     3531      +87     
  Branches      540      557      +17     
==========================================
+ Hits         1881     1934      +53     
- Misses       1400     1415      +15     
- Partials      163      182      +19
Impacted Files Coverage Δ
....Sqlite3/SqlLiteCache/SqlRawPersistentBlobCache.cs 77.58% <70.11%> (-2.5%) ⬇️
...kavache.Sqlite3/Queues/OperationQueueCoalescing.cs 89.35% <0%> (-3.05%) ⬇️
src/Akavache.Sqlite3/Queues/OperationQueue.cs 87.67% <0%> (-2.3%) ⬇️
src/Akavache.Core/BlobCache/InMemoryBlobCache.cs 59.19% <0%> (+1.72%) ⬆️
src/Akavache.Core/BulkOperationsMixin.cs 78.94% <0%> (+8.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d7799...4119e98. Read the comment docs.

@glennawatson glennawatson merged commit dfefb60 into master Aug 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-add-bulk-inserts branch August 6, 2019 17:14
@lock lock bot locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk operations take a lot of time 6.2.3 GetAll function is extremely slow.
1 participant