Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Improved readme samples and descriptions. #14

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Housekeeping: Improved readme samples and descriptions. #14

merged 2 commits into from
Mar 21, 2019

Conversation

alexmartinezm
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Readme updates include:

  • Including a new section for Android extensions and a sample.
  • A simplified generic sample for validations.

What is the current behavior? (You can also link to an open issue here)
The sample is too complex with many references.

What is the new behavior (if this is a feature change)?
Simplified sample.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
I would like to add a sample for ValidationHelper property in a ViewModel and binding to that from the View, but I think that is unnecessary.

@alexmartinezm alexmartinezm added the enhancement New feature or request label Mar 21, 2019
@alexmartinezm alexmartinezm self-assigned this Mar 21, 2019
@alexmartinezm alexmartinezm requested a review from a team March 21, 2019 09:13
README.md Outdated Show resolved Hide resolved
@glennawatson glennawatson changed the title Improved readme samples and descriptions. Housekeeping: Improved readme samples and descriptions. Mar 21, 2019
@glennawatson
Copy link
Collaborator

Looks good otherwise

@glennawatson glennawatson merged commit fe5af1b into reactiveui:master Mar 21, 2019
@lock
Copy link

lock bot commented Jun 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants