Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16: Null reference with lambdas #17

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

alexmartinezm
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix null reference when registering validations with different lambda body name.

What is the current behavior? (You can also link to an open issue here)
If you register a validation with "viewModel => viewModel.Name" and in the view you register with "vm => vm.Name", it will throw an Exception due that is comparing the full body name.

See bug: #16

What might this PR break?
Nothing.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@alexmartinezm alexmartinezm self-assigned this Apr 1, 2019
@alexmartinezm alexmartinezm requested review from a team and glennawatson April 1, 2019 10:12
Copy link
Collaborator

@worldbeater worldbeater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks as always 👍

@glennawatson glennawatson merged commit f85c741 into reactiveui:master Apr 1, 2019
@lock lock bot locked and limited conversation to collaborators Jun 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants