Use Space char as default delimiter #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Now
SingleLineFormatter
uses the " " character by default for validation error messages concatenation. I think this behavior is what a new user would expect from the library.What is the current behavior?
Before, it just concatenated the error message texts. This caused the messages to be glued to each other.
What is the new behavior?
Now the messages are concatenated using the whitespace character. This can be easily overriden by passing a custom
SingleLineFormatter
toBindValidation
, but probably using the whitespace character out-of-box will make the library more developer-friendly.What might this PR break?
Sometimes when running unit tests locally I get the following exception thrown in random tests:
This seem to happen due to a race condition in unit tests harness. The dictionary in
POCOObservableForProperty
is not concurrent, probably we should fix that:https://github.com/reactiveui/ReactiveUI/blob/eb53eee4bd1865b3a226ec468c0a344620349bee/src/ReactiveUI/ObservableForProperty/POCOObservableForProperty.cs#L21